Work around strange gcc bug #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ounds in the transform test
miscco
requested review from
alliepiper and
ericniebler
and removed request for
a team
miscco
added
thrust
jrhemstad
approved these changes
Aug 22, 2023
|
It is a highly volatile backend misscompilation involving the vectorizer via It had been coming up from time to time infrequently, so I believe any arbitrary change in one of our headers could trigger it |
|
Ah yes, that bug. I had it narrowed down to a single commit in GCC history at some point, but was never able to create a reproducer that was a reasonable reproducer to submit to upstream 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have consistent CI failures, where gcc 12 believes we would be writing out of bound elements.
That warning only happens with gcc 12 and goes away if we write one element more...